Update elasticsearch-net-breaking-changes.asciidoc #2333
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change wich to which. I think the latter is more appropriate.
gmarz
approved these changes
Oct 25, 2016
Contributor
gmarz
left a comment
gmarz
left a comment
There was a problem hiding this comment.
LGTM 👍 Thanks @szymon-judasz would you mind signing the CLA?
Contributor
|
Hey @szymon-judasz, just wondered if you'd signed the CLA for this? |
Author
|
@russcam sorry, email notifications went to spam folder (sic!). |
Mpdreamz
added a commit
that referenced
this pull request
Nov 29, 2016
Member
|
Hi @szymon-judasz I could not locate you on our CLA database so i manually applied this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change wich to which.
I think the latter is more appropriate.